Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the blog detail frontend action to use the first URL segment for the post identifier and registers a dedicated Blog Detail frontend block extra in the backend installer so blog detail pages can be configured as separate pages. Sequence diagram for blog detail request resolving first URL segmentsequenceDiagram
actor User
participant FrontendRouter
participant BlogDetailAction
participant Url
participant FrontendBlogModel
User->>FrontendRouter: GET /my-post-slug
FrontendRouter->>BlogDetailAction: dispatch detail action
BlogDetailAction->>Url: getParameter 0
Url-->>BlogDetailAction: postIdOrSlug
BlogDetailAction->>Url: getParameter revision,int
Url-->>BlogDetailAction: revisionOrNull
alt revision is null
BlogDetailAction->>FrontendBlogModel: get postIdOrSlug
FrontendBlogModel-->>BlogDetailAction: post
else revision is set
BlogDetailAction->>FrontendBlogModel: getRevision postIdOrSlug,revision
FrontendBlogModel-->>BlogDetailAction: postRevision
end
BlogDetailAction-->>FrontendRouter: render blog detail page
FrontendRouter-->>User: HTML response
Flow diagram for registering the Blog Detail frontend block extraflowchart LR
subgraph BackendInstaller
Installer[Blog Installer]
end
Installer -->|configureFrontendExtras| InsertExtraBlog[insertExtra Blog block]
Installer -->|configureFrontendExtras| InsertExtraDetail[insertExtra Detail block]
Installer -->|configureFrontendExtras| InsertExtraArchive[insertExtra Archive widget]
Installer -->|configureFrontendExtras| InsertExtraCategories[insertExtra Categories widget]
Installer -->|configureFrontendExtras| InsertExtraRecentArticlesFull[insertExtra RecentArticlesFull widget]
InsertExtraBlog --> ModuleExtras[Module extra records]
InsertExtraDetail --> ModuleExtras
InsertExtraArchive --> ModuleExtras
InsertExtraCategories --> ModuleExtras
InsertExtraRecentArticlesFull --> ModuleExtras
subgraph Frontend
BlogOverviewPage[Page with Blog block]
BlogDetailPage[Page with Detail block]
end
ModuleExtras --> BlogOverviewPage
ModuleExtras --> BlogDetailPage
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the magic index
0used ingetBlogPost()into a clearly named constant or using a named parameter (if supported), so it's obvious which URL segment is expected to hold the blog id. - For the new
Detailfrontend block extra, ensure its action name and usage are consistent with other blog extras (e.g., how it will be placed and resolved), to avoid configuration drift between installer setup and actual routing/controller behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the magic index `0` used in `getBlogPost()` into a clearly named constant or using a named parameter (if supported), so it's obvious which URL segment is expected to hold the blog id.
- For the new `Detail` frontend block extra, ensure its action name and usage are consistent with other blog extras (e.g., how it will be placed and resolved), to avoid configuration drift between installer setup and actual routing/controller behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tijsverkoyen
approved these changes
Feb 20, 2026
jonasdekeukelaere
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for a dedicated blog detail page and adjust URL parameter handling accordingly.
New Features:
Bug Fixes: